(BSR)[PRO] test: add financial management test #13982
Merged
+67
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 59391ec): https://pc-pro-testing--pr13982-ncanseco-bsr-cypress-yoa6upel.web.app (expires Sat, 07 Sep 2024 08:08:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1 |
|
A rajouter à la liste des données pour le data factory (qui corrigera le flaky by design dont tu parles): |
xdekoninck-pass
approved these changes
Sep 5, 2024
scolson-pass
reviewed
Sep 5, 2024
| @@ -14,6 +14,45 @@ When('I download reimbursement details', () => { | |||
| // }) | |||
| // }) | |||
|
|
|||
| When('I remove {string} venue from my bank account', (venue: string) => { | |||
| cy.get('[class^=_linked-venues-section_]').within(() => { | |||
There was a problem hiding this comment.
je vais regarder pour te mettre un data-testid
(BSR)[PRO] test: fix intercept url matching (BSR)[PRO] test: add a data-test-id + Prettier
scolson-pass
force-pushed
the
ncanseco/bsr-cypress-automatic-link-venue-to-bank-account
branch
from
5701d93
to
59391ec
Compare
scolson-pass
approved these changes
Sep 5, 2024
ncanseco-pass
deleted the
ncanseco/bsr-cypress-automatic-link-venue-to-bank-account
branch
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Couvre la ligne 263 du référentiel de tests.
Comme sur le compte de test ([email protected]) on avait déjà un lieu rattaché et pas d'autre lieu physique dispo, il a fallu une étape pour "détacher" le lieu du compte pour pouvoir ensuite tester le rattachement. Donc ce test est flaky par design : le compte de test peut se retrouver dans un état mal géré si il échoue en cours de route,
et échouer au retry par exemple. A voir si on peut l'améliorer par la suite.
Vérifications